chore: partial support of absl::log library #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chakaz not urgent, when you have time :) |
chakaz
previously approved these changes
May 26, 2024
Keep the default with the old glog library. Signed-off-by: Roman Gershman <romange@gmail.com>
chakaz
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the default with the old glog library. The absl log library is missing a LOT of features, like logging into files, file rotation etc. Basically it provides only the low-level api to serialize log messes into sink and a stderr sink. This is not enough for prod use. Still, this PR provides a common ground to use both libraries in neutral way. If I have bandwidth I will fill in the functionality inside helio to be able to get rid of old glog