Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reusable fibers and fiber pool #268

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BorysTheDev
Copy link
Contributor

It's just an idea. On my PC for test:
memtier_benchmark -t 8 --pipeline=30 --hide-histogram --test-time=3000 --distinct-client-seed -d 256 --ratio=1:0
I've got 19% performance improvement

@romange
Copy link
Owner

romange commented May 18, 2024

Fibers are created once when the benchmark is starting and continue running during the lifetime of the loadtest program.
Based on this PR I do not see how these changes can affect the performance of the backend, specifically the performance of processing of requests.

@BorysTheDev
Copy link
Contributor Author

Fiber creation and destruction take a significant part of CPU in our code. In my PR, I create a pool that contains all unused fibers, and next time when we need a new fiber we just get already created and don't waste time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants