Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): update linter logic for using declaration #4759

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

nissy-dev
Copy link
Contributor

Summary

Fix #4646

This PR is to update linter logic for using declaration.

Test Plan

All tests that already exist are now passed.

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit 4ea6a70
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64d259036d99de0008cc505e

@github-actions github-actions bot added A-Linter Area: linter A-Formatter Area: formatter L-JavaScript Langauge: JavaScript A-Parser Area: parser labels Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 48863 48863 0
Passed 47808 47808 0
Failed 1055 1055 0
Panics 0 0 0
Coverage 97.84% 97.84% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6212 6212 0
Passed 1764 1764 0
Failed 4448 4448 0
Panics 0 0 0
Coverage 28.40% 28.40% 0.00%

ts/babel

Test result main count This PR count Difference
Total 639 639 0
Passed 573 573 0
Failed 66 66 0
Panics 0 0 0
Coverage 89.67% 89.67% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17224 17224 0
Passed 13121 13121 0
Failed 4103 4103 0
Panics 0 0 0
Coverage 76.18% 76.18% 0.00%

@ematipico ematipico merged commit 8019850 into main Aug 8, 2023
18 of 19 checks passed
@ematipico ematipico deleted the fix-linter-for-explicit-resource-management branch August 8, 2023 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Formatter Area: formatter A-Linter Area: linter A-Parser Area: parser L-JavaScript Langauge: JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Implement the new resource managment proposal
2 participants