Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Fix "performance reason" typo #4782

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix "performance reason" typo #4782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/rome_cli/tests/snapshots/main_commands_check/check_help.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ The configuration that is contained inside the file `rome.json`
working directory. If no current working directory can't be found, Rome
won't use the VCS integration, and a diagnostic will be emitted
--files-max-size=NUMBER The maximum allowed size for source code files in bytes. Files above
this limit will be ignored for performance reason. Defaults to 1 MiB
this limit will be ignored for performance reasons. Defaults to 1 MiB
--files-ignore-unknown=<true|false> Tells Rome to not emit diagnostics when handling files that
doesn't know
--indent-style=<tab|space> The indent style.
Expand Down
2 changes: 1 addition & 1 deletion crates/rome_cli/tests/snapshots/main_commands_ci/ci_help.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ The configuration that is contained inside the file `rome.json`
working directory. If no current working directory can't be found, Rome
won't use the VCS integration, and a diagnostic will be emitted
--files-max-size=NUMBER The maximum allowed size for source code files in bytes. Files above
this limit will be ignored for performance reason. Defaults to 1 MiB
this limit will be ignored for performance reasons. Defaults to 1 MiB
--files-ignore-unknown=<true|false> Tells Rome to not emit diagnostics when handling files that
doesn't know
--indent-style=<tab|space> The indent style.
Expand Down
2 changes: 1 addition & 1 deletion crates/rome_cli/tests/snapshots/main_commands_format/format_help.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Set of properties to integrate Rome with a VCS software.

The configuration of the filesystem
--files-max-size=NUMBER The maximum allowed size for source code files in bytes. Files above
this limit will be ignored for performance reason. Defaults to 1 MiB
this limit will be ignored for performance reasons. Defaults to 1 MiB
--files-ignore-unknown=<true|false> Tells Rome to not emit diagnostics when handling files that
doesn't know

Expand Down
2 changes: 1 addition & 1 deletion crates/rome_cli/tests/snapshots/main_commands_lint/check_help.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ The configuration that is contained inside the file `rome.json`
working directory. If no current working directory can't be found, Rome
won't use the VCS integration, and a diagnostic will be emitted
--files-max-size=NUMBER The maximum allowed size for source code files in bytes. Files above
this limit will be ignored for performance reason. Defaults to 1 MiB
this limit will be ignored for performance reasons. Defaults to 1 MiB
--files-ignore-unknown=<true|false> Tells Rome to not emit diagnostics when handling files that
doesn't know
--indent-style=<tab|space> The indent style.
Expand Down
2 changes: 1 addition & 1 deletion crates/rome_service/src/configuration/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ impl MergeWith<Option<JavascriptFormatter>> for Configuration {
#[serde(rename_all = "camelCase", default, deny_unknown_fields)]
pub struct FilesConfiguration {
/// The maximum allowed size for source code files in bytes. Files above
/// this limit will be ignored for performance reason. Defaults to 1 MiB
/// this limit will be ignored for performance reasons. Defaults to 1 MiB
#[bpaf(long("files-max-size"), argument("NUMBER"))]
pub max_size: Option<NonZeroU64>,

Expand Down
2 changes: 1 addition & 1 deletion editors/vscode/configuration_schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion npm/backend-jsonrpc/src/workspace.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion npm/rome/configuration_schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions website/src/pages/cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ Run various checks on a set of files.

If Rome can't find the configuration, it will attempt to use the current working directory. If no current working directory can't be found, Rome won't use the VCS integration, and a diagnostic will be emitted
- **` --files-max-size`**=_`NUMBER`_ &mdash;
The maximum allowed size for source code files in bytes. Files above this limit will be ignored for performance reason. Defaults to 1 MiB
The maximum allowed size for source code files in bytes. Files above this limit will be ignored for performance reasons. Defaults to 1 MiB
- **` --files-ignore-unknown`**=_`<true|false>`_ &mdash;
Tells Rome to not emit diagnostics when handling files that doesn't know
- **` --indent-style`**=_`<tab|space>`_ &mdash;
Expand Down Expand Up @@ -248,7 +248,7 @@ Run various checks on a set of files.

If Rome can't find the configuration, it will attempt to use the current working directory. If no current working directory can't be found, Rome won't use the VCS integration, and a diagnostic will be emitted
- **` --files-max-size`**=_`NUMBER`_ &mdash;
The maximum allowed size for source code files in bytes. Files above this limit will be ignored for performance reason. Defaults to 1 MiB
The maximum allowed size for source code files in bytes. Files above this limit will be ignored for performance reasons. Defaults to 1 MiB
- **` --files-ignore-unknown`**=_`<true|false>`_ &mdash;
Tells Rome to not emit diagnostics when handling files that doesn't know
- **` --indent-style`**=_`<tab|space>`_ &mdash;
Expand Down Expand Up @@ -343,7 +343,7 @@ Run the formatter on a set of files.

**The configuration of the filesystem**
- **` --files-max-size`**=_`NUMBER`_ &mdash;
The maximum allowed size for source code files in bytes. Files above this limit will be ignored for performance reason. Defaults to 1 MiB
The maximum allowed size for source code files in bytes. Files above this limit will be ignored for performance reasons. Defaults to 1 MiB
- **` --files-ignore-unknown`**=_`<true|false>`_ &mdash;
Tells Rome to not emit diagnostics when handling files that doesn't know

Expand Down Expand Up @@ -412,7 +412,7 @@ Command to use in CI environments. Run various checks of a set of files.

If Rome can't find the configuration, it will attempt to use the current working directory. If no current working directory can't be found, Rome won't use the VCS integration, and a diagnostic will be emitted
- **` --files-max-size`**=_`NUMBER`_ &mdash;
The maximum allowed size for source code files in bytes. Files above this limit will be ignored for performance reason. Defaults to 1 MiB
The maximum allowed size for source code files in bytes. Files above this limit will be ignored for performance reasons. Defaults to 1 MiB
- **` --files-ignore-unknown`**=_`<true|false>`_ &mdash;
Tells Rome to not emit diagnostics when handling files that doesn't know
- **` --indent-style`**=_`<tab|space>`_ &mdash;
Expand Down
2 changes: 1 addition & 1 deletion website/src/pages/configuration.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ If you have problems with resolving the physical file, you can use the one publi
### `files.maxSize`

The maximum allowed size for source code files in bytes. Files above
this limit will be ignored for performance reason.
this limit will be ignored for performance reasons.

> Default: 1024*1024 (1MB)

Expand Down
2 changes: 1 addition & 1 deletion website/src/pages/formatter/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Available options:
configuration, it will attempt to use the current working directory. If no
current working directory can't be found, Rome won't use the VCS integration.
--files-max-size <NUMBER> The maximum allowed size for source code files in bytes. Files
above this limit will be ignored for performance reason. Defaults to 1 MiB
above this limit will be ignored for performance reasons. Defaults to 1 MiB
--stdin-file-path <PATH> A file name with its extension to pass when reading from standard
in, e.g. echo 'let a;' | rome format --stdin-file-path=file.js"
--colors <off|force> Set the formatting mode for markup: "off" prints everything as plain
Expand Down
2 changes: 1 addition & 1 deletion website/src/pages/linter/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Available options:
configuration, it will attempt to use the current working directory. If no
current working directory can't be found, Rome won't use the VCS integration.
--files-max-size <NUMBER> The maximum allowed size for source code files in bytes. Files
above this limit will be ignored for performance reason. Defaults to 1 MiB
above this limit will be ignored for performance reasons. Defaults to 1 MiB
--indent-style <tab|space> The indent style.
--indent-size <NUMBER> The size of the indentation, 2 by default
--line-width <NUMBER> What's the max width of a line. Defaults to 80.
Expand Down