core: always return nil on error

We should always return a nil pointer of clusterInfo if
CreateOrLoadClusterInfo() returns an error.

Closes: #9314
Signed-off-by: Sébastien Han <seb@redhat.com>

pkg/operator/ceph/cluster/mon/config.go

@@ -155,15 +155,15 @@ func CreateOrLoadClusterInfo(clusterdContext *clusterd.Context, context context.
 	if clusterInfo.CephCred.Secret == adminSecretNameKey {
 		secret, err := clusterdContext.Clientset.CoreV1().Secrets(namespace).Get(context, OperatorCreds, metav1.GetOptions{})
 		if err != nil {
-			return clusterInfo, maxMonID, monMapping, err
+			return nil, maxMonID, monMapping, err
 		}
 		// Populate external credential
 		clusterInfo.CephCred.Username = string(secret.Data["userID"])
 		clusterInfo.CephCred.Secret = string(secret.Data["userKey"])
 	}
 
 	if err := ValidateCephCSIConnectionSecrets(clusterdContext, namespace); err != nil {
-		return clusterInfo, maxMonID, monMapping, err
+		return nil, maxMonID, monMapping, err
 	}
 
 	return clusterInfo, maxMonID, monMapping, nil