core: close stdoutPipe

Closing stdoutPipe that could possibly leaks memory due to unclosed resources. Closes: #8914 Signed-off-by: subhamkrai <srai@redhat.com>
rook · Oct 5, 2021 · ee70937 · ee70937
1 parent 078f648
commit ee70937
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/pkg/daemon/discover/discover.go b/pkg/daemon/discover/discover.go
@@ -158,6 +158,7 @@ func rawUdevBlockMonitor(c chan string, matches, exclusions []string) {
 		logger.Warningf("Cannot open udevadm stdout: %v", err)
 		return
 	}
+	defer stdout.Close()
 
 	err = cmd.Start()
 	if err != nil {

diff --git a/pkg/util/exec/exec.go b/pkg/util/exec/exec.go
@@ -238,6 +238,7 @@ func startCommand(env []string, command string, arg ...string) (*exec.Cmd, io.Re
 	if err != nil {
 		logger.Warningf("failed to open stdout pipe: %+v", err)
 	}
+	defer stdout.Close()
 	stderr, err := cmd.StderrPipe()
 	if err != nil {
 		logger.Warningf("failed to open stderr pipe: %+v", err)