ceph: use next ceph v16.2.6 pacific version #8743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
requested changes
Sep 17, 2021
|
This pull request has merge conflicts that must be resolved before it can be merged. @leseb please rebase it. https://rook.io/docs/rook/master/development-flow.html#updating-your-fork |
Fixed in the third commit. |
travisn
reviewed
Sep 17, 2021
Yes it should, @batrick suggested that we should have had it like this for some time actually. |
leseb
force-pushed
the
next-pacific
branch
2 times, most recently
from
9a5c043
to
2bbb420
Compare
This was referenced Sep 20, 2021
Merged
leseb
force-pushed
the
next-pacific
branch
6 times, most recently
from
db74ae7
to
3f4a47e
Compare
travisn
reviewed
Sep 20, 2021
pkg/operator/ceph/file/mds/mds.go
Outdated
| // In Pacific, standby-replay daemons are stopped automatically. Older versions of Ceph require us to stop these daemons manually. | ||
| // In Pacific, standby-replay daemons are stopped automatically. Older versions of Ceph require | ||
| // us to stop these daemons manually. | ||
| // TODO: so why don't we have a version check? |
New version is out so let's use it. Signed-off-by: Sébastien Han <seb@redhat.com>
The new version v16.2.6 has a different behavior when it comes to the number of cephfs-mirror socket files. Previous version had exactly 3 and now has like way more... So let's just check for the presence of more sockets. Signed-off-by: Sébastien Han <seb@redhat.com>
The MDS core team suggested with deploy the MDS daemon first and then do the filesystem creation and configuration. Reversing the sequence lets us avoid spurious FS_DOWN warnings when creating the filesystem. Closes: rook#8745 Signed-off-by: Sébastien Han <seb@redhat.com>
travisn
approved these changes
Sep 21, 2021
10 tasks
leseb
added a commit
to leseb/rook
that referenced
this pull request
Sep 21, 2021
ceph: use next ceph v16.2.6 pacific version
travisn
added a commit
that referenced
this pull request
Sep 21, 2021
ceph: use next ceph v16.2.6 pacific version (backport #8743)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.