Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add daily jobs #8758

Merged
merged 1 commit into from Sep 27, 2021
Merged

ci: add daily jobs #8758

merged 1 commit into from Sep 27, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Sep 20, 2021

Description of your changes:

We have new jobs now:

  • one that runs both smoke and object on the next Pacific version
  • one that runs both smoke and object on Ceph master
  • one that tests the upgrade from the current pacific stable to the
    pacific devel
  • one that tests the upgrade from the current octopus stable to the
    octopus devel

Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb
Copy link
Member Author

leseb commented Sep 20, 2021

The smoke tests need #8743

@leseb leseb force-pushed the more-test branch 2 times, most recently from aa33784 to 32acb6d Compare September 20, 2021 13:23
@leseb leseb added the WIP Work in Progress label Sep 20, 2021
@leseb leseb changed the title ci: add daily jobs WIP: ci: add daily jobs Sep 20, 2021
@mergify
Copy link

mergify bot commented Sep 21, 2021

This pull request has merge conflicts that must be resolved before it can be merged. @leseb please rebase it. https://rook.io/docs/rook/master/development-flow.html#updating-your-fork

@leseb
Copy link
Member Author

leseb commented Sep 22, 2021

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Sep 22, 2021

Command rebase: failure

Pull request can't be updated with latest base branch changes
GitHub App like Mergify are not allowed to rebase pull request where .github/workflows is changed.
This pull request must be rebased manually.
err-code: C6951

@leseb leseb force-pushed the more-test branch 2 times, most recently from d1a48c8 to 68483bd Compare September 22, 2021 16:43
@mergify
Copy link

mergify bot commented Sep 22, 2021

This pull request has merge conflicts that must be resolved before it can be merged. @leseb please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork

@leseb leseb changed the title WIP: ci: add daily jobs ci: add daily jobs Sep 23, 2021
@leseb leseb removed the WIP Work in Progress label Sep 23, 2021
@leseb leseb force-pushed the more-test branch 3 times, most recently from 5eecf03 to ce57757 Compare September 24, 2021 14:27
@leseb
Copy link
Member Author

leseb commented Sep 24, 2021

@travisn @BlaineEXE jobs are passing CI.

BlaineEXE
BlaineEXE reviewed Sep 24, 2021
View reviewed changes
.github/workflows/integration-test-upgrade-suite.yaml Outdated Show resolved Hide resolved
tests/integration/ceph_upgrade_test.go Outdated Show resolved Hide resolved
tests/integration/ceph_upgrade_test.go Outdated Show resolved Hide resolved
travisn
travisn reviewed Sep 24, 2021
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the schedule is enabled

.github/workflows/daily-nightly-jobs.yml Outdated
branches:
- master
# schedule:
# - cron: "0 0 * * *" # every day at midnight
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to enable this?

@leseb leseb added the skip-ci label Sep 27, 2021
@leseb leseb removed the skip-ci label Sep 27, 2021
@leseb
ci: add daily jobs
33dbaba 
We have new jobs now:

* one that runs both smoke and object on the next Pacific version
* one that runs both smoke and object on Ceph master
* one that tests the upgrade from the current pacific stable to the
  pacific devel
* one that tests the upgrade from the current octopus stable to the
  octopus devel

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb
Copy link
Member Author

leseb commented Sep 27, 2021

@BlaineEXE @travisn daily tests passed. Added the cron now. I think we are good to go. Thanks!

@leseb leseb merged commit 8680328 into rook:master Sep 27, 2021
@leseb leseb deleted the more-test branch September 27, 2021 13:23
@travisn travisn mentioned this pull request Sep 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@BlaineEXE BlaineEXE Awaiting requested review from BlaineEXE

Assignees
No one assigned
Labels
ci upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leseb @travisn @BlaineEXE