helm: remove chart content not in common.yaml #8884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlaineEXE
commented
Sep 29, 2021
Comment on lines
-156
to
-172
| metadata: | ||
| name: rook-ceph-system-psp-users | ||
| labels: | ||
| operator: rook | ||
| storage-backend: ceph | ||
| chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}" | ||
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: ClusterRole | ||
| name: rook-ceph-system-psp-user | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: rook-ceph-system | ||
| namespace: {{ .Release.Namespace }} | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRoleBinding |
There was a problem hiding this comment.
rook-ceph-psp-user doesn't exist any more. This seems to be an old vestigial remain.
BlaineEXE
commented
Sep 29, 2021
Comment on lines
40
to
51
| - apiGroups: | ||
| - monitoring.coreos.com | ||
| resources: | ||
| - servicemonitors | ||
| - prometheusrules | ||
| verbs: | ||
| - get | ||
| - list | ||
| - watch | ||
| - create | ||
| - update | ||
| - delete |
There was a problem hiding this comment.
This is also vestigial and covered by monitoring-specific resources that now exist.
travisn
requested changes
Sep 30, 2021
BlaineEXE
force-pushed
the
remove-unused-helm-content
branch
3 times, most recently
from
e770238
to
d4ce7ef
Compare
leseb
approved these changes
Oct 6, 2021
|
@Mergifyio rebase |
Assume common.yaml is the right source of truth, and remove major content from helm charts that does not exist in common.yaml. Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
|
Command
|
leseb
force-pushed
the
remove-unused-helm-content
branch
from
d4ce7ef
to
507dfe1
Compare
|
@travisn this is ready for final review |
travisn
approved these changes
Oct 7, 2021
|
@Mergifyio backport |
|
Command
|
leseb
added a commit
that referenced
this pull request
Oct 13, 2021
helm: remove chart content not in common.yaml (backport #8884)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Assume common.yaml is the right source of truth, and remove major
content from helm charts that does not exist in common.yaml.
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.