Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Remove old rook-ceph-system-psp-users ClusterRoleBinding #8955

Closed
wants to merge 1 commit into from
Closed

core: Remove old rook-ceph-system-psp-users ClusterRoleBinding #8955

wants to merge 1 commit into from

Conversation

imle
Copy link

@imle imle commented Oct 12, 2021

Description of your changes:
Remove old rook-ceph-system-psp-users ClusterRoleBinding. The ClusterRole it references no longer exists. It is replaced by rook-ceph-system-psp.

Which issue is resolved by this Pull Request:
Resolves #6448

@imle
remove old rook-ceph-system-psp-users ClusterRoleBinding as the Clu…
84863dd 
…sterRole it references no longer exists. It is replaced by `rook-ceph-system-psp`.
@imle imle mentioned this pull request Oct 12, 2021
Closed
subhamkrai
subhamkrai requested changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commitlint is failing check this doc https://github.com/rook/rook/blob/master/Documentation/development-flow.md#commit-structure
thanks

leseb
leseb reviewed Oct 12, 2021
View reviewed changes
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@travisn when do you remember when this went away in the master branch? So we can at least reference this as a backport...

@travisn
Copy link
Member

travisn commented Oct 12, 2021

@travisn when do you remember when this went away in the master branch? So we can at least reference this as a backport...

It was with #8884. @BlaineEXE Shall we just backport that full PR instead of just applying this one change?

@BlaineEXE
Copy link
Member

@travisn when do you remember when this went away in the master branch? So we can at least reference this as a backport...

It was with #8884. @BlaineEXE Shall we just backport that full PR instead of just applying this one change?

I think that is a cleaner and safe thing to do, yes.

@BlaineEXE
Copy link
Member

Backport is here #8961

@travisn
Copy link
Member

travisn commented Oct 12, 2021

@imle Thanks for the contribution! By some coincidence it was just already taken care of with another change so we will close this one.

@travisn travisn closed this Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb left review comments

@subhamkrai subhamkrai subhamkrai requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@imle @travisn @BlaineEXE @leseb @subhamkrai