Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mon: run ceph commands to mon with timeout #8939

Merged
merged 1 commit into from Oct 8, 2021
Merged

mon: run ceph commands to mon with timeout #8939

merged 1 commit into from Oct 8, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Oct 8, 2021

Description of your changes:

If the mons are not in quorum yet the commands interacting with mon
config store will stale for a very long time.

Closes: #8928
Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb
mon: run ceph commands to mon with timeout
8da68bf 
If the mons are not in quorum yet the commands interacting with mon
config store will stale for a very long time.

Closes: rook#8928
Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb requested a review from travisn October 8, 2021 13:14
travisn
travisn approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for now. As discussed, in a future change we should really add a timeout to all the commands.

@travisn travisn merged commit c628ede into rook:master Oct 8, 2021
This was referenced Oct 8, 2021
Closed
Merged
mergify bot added a commit that referenced this pull request Oct 8, 2021
@mergify
Merge pull request #8945 from rook/mergify/bp/release-1.7/pr-8939
b01f085 
mon: run ceph commands to mon with timeout (backport #8939)
@leseb leseb deleted the fix-8928 branch October 11, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
ceph-mon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enabling HealthCheck during 'Configuring Ceph Mon' phase make rook-ceph-operator to stuck forever
2 participants
@leseb @travisn