Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: run ceph commands to mon with timeout (backport #8939) #8944

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 8, 2021

This is an automatic backport of pull request #8939 done by Mergify.
Cherry-pick of 8da68bf has failed:

On branch mergify/bp/release-1.6/pr-8939
Your branch is up to date with 'origin/release-1.6'.

You are currently cherry-picking commit 8da68bfb7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   pkg/operator/ceph/cluster/mgr/mgr_test.go
	modified:   pkg/operator/ceph/config/monstore.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   pkg/operator/ceph/cluster/cephstatus_test.go
	both modified:   pkg/operator/ceph/config/monstore_test.go
	both modified:   pkg/operator/ceph/pool/controller_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

If the mons are not in quorum yet the commands interacting with mon
config store will stale for a very long time.

Closes: #8928
Signed-off-by: Sébastien Han <seb@redhat.com>
(cherry picked from commit 8da68bf)

# Conflicts:
#	pkg/operator/ceph/cluster/cephstatus_test.go
#	pkg/operator/ceph/config/monstore_test.go
#	pkg/operator/ceph/pool/controller_test.go
@mergify mergify bot added the conflicts label Oct 8, 2021
@leseb
Copy link
Member

leseb commented Oct 11, 2021

This does not seem to be a critical fix for 1.6, so closing.

@leseb leseb closed this Oct 11, 2021
@leseb leseb deleted the mergify/bp/release-1.6/pr-8939 branch October 11, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant