Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mon: set cluster name to mon cluster #9203

Merged
merged 1 commit into from Nov 18, 2021
Merged

mon: set cluster name to mon cluster #9203

merged 1 commit into from Nov 18, 2021

Conversation

parth-gr
Copy link
Member

the mon cluster clusterInfo is intiated seprately,
and misses out to set the cluster name and use default name as testing
from AdminClusterInfo.

Part-of: #9159
Signed-off-by: parth-gr paarora@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@parth-gr
mon: set cluster name to mon cluster
aea2856 
the mon cluster clusterInfo is intiated seprately,
and misses out to set the cluster name and use default name as testing
from AdminClusterInfo.

Part-of: rook#9159
Signed-off-by: parth-gr <paarora@redhat.com>
@parth-gr parth-gr mentioned this pull request Nov 18, 2021
Merged
10 tasks
travisn
travisn approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to fix the issue at hand with "testing" in the labels. I'm also going to look at a deeper change to how AdminClusterInfo() is used so we can avoid this in the non-test code.

@travisn travisn merged commit 3367f7e into rook:master Nov 18, 2021
@mergify mergify bot mentioned this pull request Nov 18, 2021
Merged
mergify bot added a commit that referenced this pull request Nov 18, 2021
@mergify
Merge pull request #9206 from rook/mergify/bp/release-1.7/pr-9203
e1e01c7 
mon: set cluster name to mon cluster (backport #9203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@parth-gr @travisn