core: create rook resources with k8s recommended labels

[parth-gr]

Adding Recommended Labels on the resources created by rook
and using Recommended Labels in the helm chart,
for better visuals and management of k8s object

Signed-off-by: parth-gr paarora@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #8400

Checklist:

• Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
• Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
• Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
• Reviewed the developer guide on Submitting a Pull Request
• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• Integration tests have been added, if necessary.
• Pending release notes updated with breaking and/or notable changes, if necessary.
• Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
• Code generation (make codegen) has been run to update object specifications, if necessary.

[BlaineEXE]

I don't see these changes reflected in crds.yaml or common.yaml. It seems that they should be there also.

[travisn]

From discussion, we will need to add these as new labels rather than replacing existing labels.

Something else to be aware of is that in the various helpers for adding labels:

• If there is a helper with the includeNewLabels flag, only add these labels if true
• The rook and ceph versions are already added as labels on the ceph daemon deployments, but not the pods. We don't want the version labels on the pods since it may cause an unnecessary pod restart during upgrade if nothing else changed in the pod spec.

[BlaineEXE]

@BlaineEXE ,

"app.kubernetes.io/instance": "a",

I am applying cfg.ID the daemon ID, should I apply resourceName-DaemonID ?

"app.kubernetes.io/instance": "my-store",

my-store is the objectStoreName which I have specified, cephObjectStore.Name, should Any other detail need to specify?

cephObjectStore.Name should be for app.kubernetes.io/part-of, which it is currently. The instance should be a unique name in the namespace (with the caveat that it might also be distinguished by app.kubernetes.io/component). I think it's best to make sure that instance is <name>-<id>, based on examples in the docs.

[travisn]

After the CI is fixed I'd propose we go ahead and merge. I've marked this as a blocker for 1.8 so we can start have these labels in the new release. Thanks!

[travisn]

looks like a bunch of extra rbac was mistakenly generated

[mergify]

This pull request has merge conflicts that must be resolved before it can be merged. @parth-gr please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork

[travisn]

The labels look good to me on the majority of pods, so I would recommend we go ahead with this. We can follow up with a separate PR to add the labels on the other resources such as jobs, secrets, and configmaps.

[BlaineEXE]

The labels look good to me on the majority of pods, so I would recommend we go ahead with this. We can follow up with a separate PR to add the labels on the other resources such as jobs, secrets, and configmaps.

sounds good