core: Remove support for machine disruption budgets #11450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The machine disruption budgets for handling openshift machines and machinesets are now removed since they have been unused and unmaintained since implemented. This feature is expected to be handled with the more common Pod Disruption Budgets. A workaround is for the cluster admin to set up their machine sets so they match the zone topology. See the original design doc from the feature here: https://github.com/rook/rook/blob/master/design/ceph/ceph-openshift-fencing-mitigation.md Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
travisn
force-pushed
the
remove-machine-budgets
branch
from
eafbc2b
to
25ac236
Compare
BlaineEXE
approved these changes
Dec 16, 2022
|
🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
The machine disruption budgets for handling openshift machines and machinesets are now removed since they have been unused and unmaintained since implemented. This feature is expected to be handled with the more common Pod Disruption Budgets. See the original design doc from the feature here:
https://github.com/rook/rook/blob/master/design/ceph/ceph-openshift-fencing-mitigation.md
An alternate approach to this feature is for the cluster admin to set up their machine sets so they match the zone topology.
This unused code is also causing the update to the latest go modules to currently fail in #11421.
The settings remain in the CRD with a simple deprecation comment for backward compatibility. Since the default settings were included in the cluster.yaml, even though the default was to disable the feature, it will cause upgrade issues if the settings are specified at all.
Checklist:
skip-cion the PR.