docs: update ruleNamesapce to rulesNamespaceOverride #12190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
requested changes
May 4, 2023
| # externalMgrEndpoints: | ||
| #- ip: ip | ||
| # externalMgrPrometheusPort: 9283 | ||
| #- ip: ip |
There was a problem hiding this comment.
Need to add indentation back to these last two lines
| @@ -48,10 +48,10 @@ If this value is empty, each pod will get an ephemeral directory to store their | |||
| * `enabled`: Whether to enable prometheus based monitoring for external or internal cluster | |||
| * `externalMgrEndpoints`: external cluster manager endpoints | |||
| * `externalMgrPrometheusPort`: external prometheus manager module port. See [external cluster configuration](#external-cluster) for more details. | |||
| * `rulesNamespace`: Namespace to deploy prometheusRule. If empty, namespace of the cluster will be used. | |||
| * `rulesNamespaceOverride`: Namespace to deploy prometheusRule. If empty, namespace of the cluster will be used. | |||
There was a problem hiding this comment.
Actually this setting isn't in the cluster CRD anymore, it's only a helm setting, so we need to delete this and its sub-bullets
parth-gr
force-pushed
the
doc-update-rulenamespace
branch
from
6764793
to
babe36c
Compare
travisn
requested changes
May 8, 2023
parth-gr
force-pushed
the
doc-update-rulenamespace
branch
4 times, most recently
from
b887425
to
9cb1e5a
Compare
|
And what was the reason for removing the rulesNmespace? |
See #9837 for background on the change |
travisn
requested changes
May 9, 2023
| Recommended: | ||
| * If you have a single Rook cluster, set the `rulesNamespace` to the same namespace as the cluster or keep it empty. | ||
| * If you have multiple Rook clusters in the same Kubernetes cluster, choose the same namespace to set `rulesNamespace` for all the clusters (ideally, namespace with prometheus deployed). Otherwise, you will get duplicate alerts with duplicate alert definitions. | ||
| * `externalMgrPrometheusPort`: external prometheus manager module port. See [external cluster configuration](#external-cluster) for more details.` |
There was a problem hiding this comment.
Suggested change
| * `externalMgrPrometheusPort`: external prometheus manager module port. See [external cluster configuration](#external-cluster) for more details.` | |
| * `externalMgrPrometheusPort`: external prometheus manager module port. See [external cluster configuration](#external-cluster) for more details. |
there were some places where rulenamesapce was present updated to rulesNamespaceOverride Closes: rook#12163 Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr
force-pushed
the
doc-update-rulenamespace
branch
from
9cb1e5a
to
060bd00
Compare
travisn
approved these changes
May 11, 2023
travisn
added a commit
that referenced
this pull request
May 15, 2023
docs: update ruleNamesapce to rulesNamespaceOverride (backport #12190)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
there were some places where rulenamesapce was present updated to rulesNamespaceOverride
Which issue is resolved by this Pull Request:
Resolves #12163
Checklist:
skip-cion the PR.