Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: implement support for creating swift sub-users via the user CR #13808

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

rgw: implement support for creating swift sub-users via the user CR #13808

wants to merge 10 commits into from

Conversation

Lykos153
Copy link

@Lykos153 Lykos153 commented Feb 22, 2024 •
edited

This PR implements using k8s custom resources to create swift sub-users as described in the already existing design document swift-and-keystone-integration (see #9444 for the design request and #9088 for the general issue).

The design document describes another feature namely the authentication using keystone of swift and s3 which is implemented in a #13807.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@Lykos153 Lykos153 marked this pull request as draft February 22, 2024 09:46
@Lykos153 Lykos153 force-pushed the feature/swift-subusers branch 3 times, most recently from a6ac45b to 198b47b Compare February 22, 2024 11:58
@Lykos153 Lykos153 changed the title rgw: implement support for creating swift sub-users via CRs rgw: implement support for creating swift sub-users via the user CR Feb 22, 2024
@Lykos153 Lykos153 marked this pull request as ready for review February 22, 2024 12:59
@BlaineEXE BlaineEXE mentioned this pull request Feb 22, 2024
Open
6 tasks
@BlaineEXE
Copy link
Member

Related to #13807 : is either of these PRs needed as a basis for the other?

@Lykos153
Copy link
Author

They don't strictly depend on each other. Each will do what it's meant to do on its own. However, creating sub-users probably isn't that useful without also being able to configure Swift.

@Lykos153
Copy link
Author

I just realized I missed something in this one, so I'm converting it back to a Draft for now.

@Lykos153 Lykos153 marked this pull request as draft February 23, 2024 12:38
@mergify Mergify
Copy link

mergify bot commented Feb 28, 2024

This pull request has merge conflicts that must be resolved before it can be merged. @Lykos153 please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

1 similar comment
@mergify Mergify
Copy link

mergify bot commented Mar 4, 2024

This pull request has merge conflicts that must be resolved before it can be merged. @Lykos153 please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

Lykos153 and others added 4 commits April 2, 2024 16:15
@Lykos153
docs: fix minor mistakes in design document
dd952c5 
The design document for the swift and keystone integration contains
incorrectly numbered annotations.

Thie commit fixes the numeration of the annotations. Additionally
some minor wording changes are made.

Signed-off-by: Silvio Ankermann <silvio.ankermann@cloudandheat.com>
@sebastianriese @Lykos153
rgw: extend the API object specs for swift and keystone integration
0fa79fc 
For the specification see:
<https://github.com/rook/rook/blob/master/design/ceph/object/swift-and-keystone-integration.md>

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
Signed-off-by: Silvio Ankermann <silvio.ankermann@cloudandheat.com>
@sebastianriese @jklippel @Lykos153
rgw: adapt rgw to the new go-ceph version
e6dffef 
* The parameter lists of the API call have changes, as parameters
  ignored by the RGW Admin Ops API are no longer serialized,
  therefore the mock has to be adapted.

* There is now validation for the user keys that are passed to
  the User get API, therefore things failed when we had empty
  keys in our User proxy object.

Co-authored-by: Jan Klippel <jan.klippel@uhurutec.com>
Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
Signed-off-by: Silvio Ankermann <silvio.ankermann@cloudandheat.com>
@sebastianriese @jklippel @Lykos153
rgw: expand the reconcile loop for the swift and keystone integration
0571608 
For the specification see:
<https://github.com/rook/rook/blob/master/design/ceph/object/swift-and-keystone-integration.md>

Co-authored-by: Jan Klippel <jan.klippel@uhurutec.com>
Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
Signed-off-by: Silvio Ankermann <silvio.ankermann@cloudandheat.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Labeled by the stale bot label Apr 3, 2024
@mergify Mergify
Copy link

mergify bot commented Apr 3, 2024

This pull request has merge conflicts that must be resolved before it can be merged. @Lykos153 please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

@github-actions github-actions bot removed the stale Labeled by the stale bot label Apr 4, 2024
sebastianriese and others added 6 commits April 9, 2024 15:58
@sebastianriese @Lykos153
rgw: extend the API object specs for Swift user management
4c5e4f0 
For the specification see:
<https://github.com/rook/rook/blob/master/design/ceph/object/swift-and-keystone-integration.md>

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
Signed-off-by: Silvio Ankermann <silvio.ankermann@cloudandheat.com>
@sebastianriese @Lykos153
rgw: expand the reconcile loop for the Swift user management
23d3b65 
For the specification see:
<https://github.com/rook/rook/blob/master/design/ceph/object/swift-and-keystone-integration.md>

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
Signed-off-by: Silvio Ankermann <silvio.ankermann@cloudandheat.com>
@sebastianriese @Lykos153
rgw: add unit tests for the Swift user management
ecfd0eb 
For the specification of the swift and keystone integration see:
<https://github.com/rook/rook/blob/master/design/ceph/object/swift-and-keystone-integration.md>

Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com>
Signed-off-by: Silvio Ankermann <silvio.ankermann@cloudandheat.com>
@Lykos153
rgw: add documentation for swift subusers
9172a03 
Signed-off-by: Silvio Ankermann <silvio.ankermann@cloudandheat.com>
@Lykos153
endpoint
7a98258
@Lykos153
WIP
07443af
@ideepika
Copy link

Key @Lykos153 this is great work! We are interested in speeding this PR up as well, can you address review comments or let us know if we can help you. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn Awaiting requested review from travisn

@alimaredia alimaredia Awaiting requested review from alimaredia

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Lykos153 @BlaineEXE @ideepika @sebastianriese