pool: Return error if device class update fails #14057
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
force-pushed
the
deviceclass-log
branch
3 times, most recently
from
49e4b85
to
68928ea
Compare
Updating the device class swallowed any error if updated for the pool. The error was not even logged, so we couldn't troubleshoot why the new crush rule was not applied. Log the error for troubleshooting and also fail the pool reconcile since the desired configuration was not applied. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
The ceph command prints errors to stderr and is being ignored by failures in most of the pool commands, which makes troubleshooting difficult when there is a failure. Include the output now for all the pool commands in case of failure. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the device class swallowed any error if updated for the pool. The error was not even logged, so we couldn't troubleshoot why the new crush rule was not applied. Log the error for troubleshooting and also fail the pool reconcile since the desired configuration was not applied.
As I recall, there was some concern in the past about best effort vs failing the reconcile when updating the crush rule for the pool. But now it seems like the wrong decision that the best effort approach was taken since it hid any errors about setting the expected pool's crush rule.
Checklist: