osd: Prevent osd reconcile when device set names duplicated (backport #14002) #14065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
If device set names are duplicated, the OSDs will be very confused when multiple OSDs attempt to be configured with the same device set names. Updating the device set names does not help get out of the error situation since the OSDs will also be confused about which device set they belong to. The reconcile must fail completely if the device set names are duplicated to avoid this error scenario. Signed-off-by: Travis Nielsen <tnielsen@redhat.com> (cherry picked from commit 7f68d8b)
travisn
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If device set names are duplicated, the OSDs will be very confused when multiple OSDs attempt to be configured with the same device set names. Updating the device set names does not help get out of the error situation since the OSDs will also be confused about which device set they belong to. The reconcile must fail completely if the device set names are duplicated to avoid this error scenario.
Checklist:
This is an automatic backport of pull request #14002 done by [Mergify](https://mergify.com).