Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: fix mon scaledown when mons are portable (backport #14106) #14132

Merged
merged 1 commit into from Apr 29, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 25, 2024

in case of portable mons, mon scaledown was skipped with below code

if mon.NodeName == "" {
			logger.Debugf("mon %q is not scheduled to a specific host", mon.DaemonName)
			continue
		}

which skips mon removal if mon nodeName is empty
but if mons are scale down in case of portable mons in that case also we want to remove extra mons to match the cephCluster configuration.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

This is an automatic backport of pull request #14106 done by [Mergify](https://mergify.com).

in case of portable mons, mon scaledown was skipped
with below code
```
if mon.NodeName == "" {
			logger.Debugf("mon %q is not scheduled to a specific host", mon.DaemonName)
			continue
		}
```
which skips mon removal if mon nodeName is empty
but if mons are scale down in case of portable mons
in that case also we want to remove extra mons to match
the cephCluster configuration.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit d23a843)
@mergify mergify bot merged commit f7127c8 into release-1.14 Apr 29, 2024
52 checks passed
@mergify mergify bot deleted the mergify/bp/release-1.14/pr-14106 branch April 29, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants