ci: add multus canary test without holder pods #14159
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts that must be resolved before it can be merged. @subhamkrai please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork |
BlaineEXE
reviewed
May 7, 2024
| @@ -1614,7 +1614,7 @@ jobs: | |||
| name: ${{ github.job }}-${{ matrix.ceph-image }} | |||
| additional-namespace: kube-system | |||
|
|
|||
| csi-hostnetwork-disabled: | |||
| multus-cluster-network-without-holder: | |||
There was a problem hiding this comment.
Could we also rename the test above to be multus-cluster-network-with-holder so it's clear in the outputs which is which?
BlaineEXE
reviewed
May 7, 2024
|
|
||
| - name: wait for prepare pod | ||
| run: tests/scripts/github-action-helper.sh wait_for_prepare_pod 2 | ||
|
|
||
| - name: wait for ceph to be ready | ||
| run: IS_POD_NETWORK=true tests/scripts/github-action-helper.sh wait_for_ceph_to_be_ready osd 2 | ||
| run: IS_POD_NETWORK=true IS_MULTUS=true tests/scripts/github-action-helper.sh wait_for_ceph_to_be_ready osd 2 |
There was a problem hiding this comment.
Won't IS_MULTUS=true cause the test to fail because of the block below?
tests/scripts/validate_cluster.sh:
if [ -n "$IS_MULTUS" ]; then
echo "verifying csi holder interfaces (multus ones must be present)"
kubectl -n rook-ceph exec -t ds/csi-rbdplugin-holder-my-cluster -- grep eth0 /proc/net/dev
kubectl -n rook-ceph exec -t ds/csi-cephfsplugin-holder-my-cluster -- grep eth0 /proc/net/dev
kubectl -n rook-ceph exec -t ds/csi-nfsplugin-holder-my-cluster -- grep eth0 /proc/net/dev
fi
There was a problem hiding this comment.
yeah probably and also the routing part is still pending to add
subhamkrai
force-pushed
the
add-multus-ci-without-holder-pods
branch
2 times, most recently
from
fb6c912
to
c7d7e12
Compare
this commit adds changes to deploy multus with holder pods disabled and also remove ci test csi-hostnetwork-disabled as this not really not supported in rook. Signed-off-by: subhamkrai <srai@redhat.com>
subhamkrai
force-pushed
the
add-multus-ci-without-holder-pods
branch
from
c7d7e12
to
4a39b31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit adds changes to deploy multus with
holder pods disabled and also remove ci test
csi-hostnetwork-disabled as this not really not
supported in rook.
Issue resolved by this Pull Request:
Resolves #13922
Checklist: