Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add missing markdownlint CI step #14178

Merged
merged 1 commit into from May 8, 2024
Merged

ci: add missing markdownlint CI step #14178

merged 1 commit into from May 8, 2024

Conversation

BlaineEXE
Copy link
Member

The CI step that runs markdown lint accidentally got removed as part of PR updates. Add the CI step back in.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@BlaineEXE BlaineEXE force-pushed the fix-markdownlint-missing-ci branch from 3403b6e to 34fcb22 Compare May 8, 2024 16:55
@BlaineEXE
ci: add missing markdownlint CI step
115e0aa 
The CI step that runs markdown lint accidentally got removed as part of
PR updates. Add the CI step back in.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
@BlaineEXE BlaineEXE force-pushed the fix-markdownlint-missing-ci branch from 34fcb22 to 115e0aa Compare May 8, 2024 16:55
@BlaineEXE BlaineEXE marked this pull request as ready for review May 8, 2024 16:56
@BlaineEXE BlaineEXE mentioned this pull request May 8, 2024
Merged
6 tasks
@BlaineEXE BlaineEXE requested review from galexrt and travisn May 8, 2024 16:57
@BlaineEXE BlaineEXE added the docs label May 8, 2024
@BlaineEXE BlaineEXE merged commit 5e3d623 into rook:master May 8, 2024
52 of 53 checks passed
@BlaineEXE BlaineEXE deleted the fix-markdownlint-missing-ci branch May 8, 2024 17:19
@mergify mergify bot mentioned this pull request May 8, 2024
Merged
6 tasks
travisn added a commit that referenced this pull request May 9, 2024
@travisn
Merge pull request #14179 from rook/mergify/bp/release-1.14/pr-14178
8a826c9 
ci: add missing markdownlint CI step (backport #14178)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@galexrt galexrt Awaiting requested review from galexrt

Assignees
No one assigned
Labels
backport-release-1.14 docs skip-ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BlaineEXE @travisn