New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ceph: add peer spec migration to upgrade doc #8435
Merged
leseb
merged 2 commits into
rook:master
from
BlaineEXE:upgrade-doc-add-mirroring-changes
Sep 15, 2021
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -373,6 +373,34 @@ At this point, your Rook operator should be running version `rook/ceph:v1.7.0`. | |
|
||
Verify the Ceph cluster's health using the [health verification section](#health-verification). | ||
|
||
### **6. Update CephRBDMirror and CephBlockPool configs** | ||
|
||
If you are not using a `CephRBDMirror` in your Rook cluster, you may disregard this section. | ||
|
||
Otherwise, please note that the location of the `CephRBDMirror` `spec.peers` config has moved to | ||
`CephBlockPool` `spec.mirroring.peers` in Rook v1.7. This change allows each pool to have its own | ||
peer and enables pools to re-use an existing peer secret if it points to the same cluster peer. | ||
|
||
You may wish to see the [CephBlockPool spec Documentation](ceph-pool-crd.md#spec) for the latest | ||
configuration advice. | ||
|
||
The pre-existing config location in `CephRBDMirror` `spec.peers` will continue to be supported, but | ||
users are still encouraged to migrate this setting from `CephRBDMirror` to relevant `CephBlockPool` | ||
resources. | ||
Comment on lines
+387
to
+389
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes it is. |
||
|
||
To migrate the setting, follow these steps: | ||
1. Stop the Rook-Ceph operator by downscaling the Deployment to zero replicas. | ||
```sh | ||
kubectl -n $ROOK_OPERATOR_NAMESPACE scale deployment rook-ceph-operator --replicas=0 | ||
``` | ||
2. Copy the `spec.peers` config from `CephRBDMirror` to every `CephBlockPool` in your cluster that | ||
has mirroring enabled. | ||
3. Remove the `peers` spec from the `CephRBDMirror` resource. | ||
4. Resume the Rook-Ceph operator by scaling the Deployment back to one replica. | ||
```sh | ||
kubectl -n $ROOK_OPERATOR_NAMESPACE scale deployment rook-ceph-operator --replicas=1 | ||
``` | ||
|
||
|
||
## Ceph Version Upgrades | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the
(Ceph Octopus release)
sidebar here is particularly useful for users. This only becomes relevant once a Ceph version does support multiple peers.