docs: Refactor documentation for ceph provider #8693
Merged
+357
−492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoru-takeuchi
approved these changes
Sep 13, 2021
leseb
reviewed
Sep 13, 2021
Documentation/quickstart.md
Outdated
|
|
||
| ## TL;DR | ||
|
|
||
| If you're feeling lucky, a simple Rook cluster can be created with the following kubectl commands and [example manifests](https://github.com/rook/rook/blob/{{ branchName }}/cluster/examples/kubernetes/ceph). |
There was a problem hiding this comment.
The "feeling lucky" lacks a bit of confidence even though it probably has a humoristic tone. Should we keep it?
There was a problem hiding this comment.
Yeah I think it's better to remove
jmolmo
approved these changes
Sep 13, 2021
With the nfs and cassandra providers moving to their own repo we can simplify the docs a bit. Some obsolete documentation is also removed. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
travisn
force-pushed
the
cleanup-docs
branch
from
0b5c6c8
to
6b7062e
Compare
leseb
approved these changes
Sep 13, 2021
travisn
added a commit
that referenced
this pull request
Sep 13, 2021
docs: Refactor documentation for ceph provider (backport #8693)
parth-gr
pushed a commit
to parth-gr/rook
that referenced
this pull request
Sep 14, 2021
docs: Refactor documentation for ceph provider Signed-off-by: parth-gr <paarora@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
With the nfs and cassandra providers moving to their own repo we can simplify the Ceph docs a bit. Some obsolete documentation is also removed.
Checklist:
make codegen) has been run to update object specifications, if necessary.