Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: add ldap configs for rgw #8750

Closed
wants to merge 1 commit into from
Closed

ceph: add ldap configs for rgw #8750

wants to merge 1 commit into from

Conversation

thotz
Copy link
Contributor

@thotz thotz commented Sep 17, 2021

The Ceph Object Gateway supports integrating with LDAP for authenticating
and creating users, for that required config options need to be added in
cephobjectstore CRD.

Resolves #4315
Signed-off-by: Jiffin Tony Thottan thottanjiffin@gmail.com
Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@mergify mergify bot added the ceph main ceph tag label Sep 17, 2021
BlaineEXE
BlaineEXE requested changes Sep 17, 2021
View reviewed changes
Copy link
Member

@BlaineEXE BlaineEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's design more explicitly for usability and developer understanding.

Also, I will again ask where the unit tests are for this feature.

We will want community help testing this feature, and it would be most helpful if someone could help us set up an integration test for this so that we can be sure we aren't breaking it in the future.

pkg/apis/ceph.rook.io/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/ceph.rook.io/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/ceph.rook.io/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/ceph.rook.io/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/ceph.rook.io/v1/types.go Outdated Show resolved Hide resolved
cluster/examples/kubernetes/ceph/object-openshift.yaml Outdated Show resolved Hide resolved
cluster/examples/kubernetes/ceph/object-openshift.yaml Outdated Show resolved Hide resolved
cluster/examples/kubernetes/ceph/object-openshift.yaml Outdated Show resolved Hide resolved
pkg/operator/ceph/object/config.go Outdated Show resolved Hide resolved
cluster/examples/kubernetes/ceph/object-openshift.yaml Outdated Show resolved Hide resolved
leseb
leseb requested changes Sep 20, 2021
View reviewed changes
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need unit tests for the spec generation, thanks!

pkg/apis/ceph.rook.io/v1/types.go
// LDAP represents ldap settings
// +optional
// +nullable
LDAP *LDAPSpec `json:"ldap,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be in a higher level Spec. LDAP and OPA for instance could fall under the same category. Perhaps something 'IdentityManagement?

pkg/apis/ceph.rook.io/v1/types.go Show resolved Hide resolved
@mergify
Copy link

mergify bot commented Sep 24, 2021

This pull request has merge conflicts that must be resolved before it can be merged. @thotz please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Labeled by the stale bot label Oct 24, 2021
@thotz thotz added keepalive and removed stale Labeled by the stale bot labels Oct 25, 2021
@travisn travisn added this to In progress in v1.8 via automation Oct 29, 2021
@travisn travisn removed this from In progress in v1.8 Oct 29, 2021
@travisn travisn mentioned this pull request Jan 20, 2022
Open
@thotz thotz force-pushed the ldaprgwsupport branch 3 times, most recently from 6bce2ab to 8df4b4b Compare February 11, 2022 04:40
@travisn
Copy link
Member

travisn commented Apr 1, 2022

@thotz There are a number of old comments and questions on this PR, what is the status? According to the discussion in #4315, there is still interest in completing this work. Thanks!

@thotz
Copy link
Contributor Author

thotz commented Apr 4, 2022

@thotz There are a number of old comments and questions on this PR, what is the status? According to the discussion in #4315, there is still interest in completing this work. Thanks!

One of the ideas was from @leseb to merge this with opa feature, I was not intended to test both features and it kinda blocked me from further development. I will refresh this PR by addressing existing commands

@mergify
Copy link

mergify bot commented May 18, 2022

This pull request has merge conflicts that must be resolved before it can be merged. @thotz please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork

@thotz
object: add ldap configs for rgw
25f3198 
The Ceph Object Gateway supports integrating with LDAP for authenticating
and creating users, for that required config options need to be added in
cephobjectstore CRD.

Resolves# 4315
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
@mergify
Copy link

mergify bot commented Jul 14, 2022

This pull request has merge conflicts that must be resolved before it can be merged. @thotz please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

@cccsss01
Copy link

I am interested in this as well!

@mergify
Copy link

mergify bot commented Sep 27, 2022

This pull request has merge conflicts that must be resolved before it can be merged. @thotz please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

This was referenced Sep 28, 2022
Closed
Closed
@travisn
Copy link
Member

travisn commented Nov 7, 2022

Closing in favor of #11091

@travisn travisn closed this Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb requested changes

@BlaineEXE BlaineEXE BlaineEXE requested changes

Assignees
No one assigned
Labels
ceph main ceph tag keepalive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support RGW LDAP integration
5 participants
@thotz @travisn @cccsss01 @leseb @BlaineEXE