ceph: retry object health check if creation fails (backport #8708) #8760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the CephObjectStore health checker fails to be created, return a
reconcile failure so that the reconcile will be run again and Rook will
retry creating the health checker. This also means that Rook will not
list the CephObjectStore as ready if the health checker can't be
started.
Resolved backport conflicts in the below files:
pkg/operator/ceph/object/controller.go
- revert monitoring routine struct change from 1.7 to master
pkg/operator/ceph/object/controller_test.go
- use master branch's rearchitected test harness
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
(cherry picked from commit 5383ba2)
|
LGTM, but rerunning the helm suite to confirm if it was an intermittent issue... |
leseb
previously requested changes
Sep 21, 2021
There was a problem hiding this comment.
It looks like the Helm failed again so I re-ran but I think we need to investigate? @BlaineEXE
travisn
dismissed
leseb’s stale review
Helm tests are separate from this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the CephObjectStore health checker fails to be created, return a
reconcile failure so that the reconcile will be run again and Rook will
retry creating the health checker. This also means that Rook will not
list the CephObjectStore as ready if the health checker can't be
started.
Resolved backport conflicts in the below files:
pkg/operator/ceph/object/controller.go
- revert monitoring routine struct change from 1.7 to master
pkg/operator/ceph/object/controller_test.go
- use master branch's rearchitected test harness
Signed-off-by: Blaine Gardner blaine.gardner@redhat.com
(cherry picked from commit 5383ba2)
backport of #8708
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.