Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: add missing rights rook-ceph-purge-osd account #8833

Merged
merged 1 commit into from Sep 28, 2021
Merged

ceph: add missing rights rook-ceph-purge-osd account #8833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cluster/charts/rook-ceph-cluster/templates/role.yaml
View file
Open in desktop
Expand Up @@ -82,7 +82,7 @@ rules:
verbs: ["get", "list", "delete" ]
- apiGroups: [""]
resources: ["persistentvolumeclaims"]
verbs: ["delete"]
verbs: ["get", "update", "delete"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't get sufficient?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update might also be needed because we remove the ceph.rook.io/DeviceSetPVCId label from the pvc if its decided to be preserved.


{{- if .Values.monitoring.enabled }}
---
Expand Down
2 changes: 1 addition & 1 deletion cluster/charts/rook-ceph/templates/role.yaml
View file
Open in desktop
Expand Up @@ -188,5 +188,5 @@ rules:
verbs: ["get", "list", "delete" ]
- apiGroups: [""]
resources: ["persistentvolumeclaims"]
verbs: ["delete"]
verbs: ["get", "update", "delete"]
{{- end }}
2 changes: 1 addition & 1 deletion cluster/examples/kubernetes/ceph/common-second-cluster.yaml
View file
Open in desktop
Expand Up @@ -145,7 +145,7 @@ rules:
verbs: ["get", "list", "delete"]
- apiGroups: [""]
resources: ["persistentvolumeclaims"]
verbs: ["delete"]
verbs: ["get", "update", "delete"]
---
# Allow the osd purge job to run in this namespace
kind: RoleBinding
Expand Down
2 changes: 1 addition & 1 deletion cluster/examples/kubernetes/ceph/common.yaml
View file
Open in desktop
Expand Up @@ -1195,7 +1195,7 @@ rules:
verbs: ["get", "list", "delete"]
- apiGroups: [""]
resources: ["persistentvolumeclaims"]
verbs: ["delete"]
verbs: ["get", "update", "delete"]
---
# Allow the osd purge job to run in this namespace
kind: RoleBinding
Expand Down