csi: No longer install the VolumeReplication CRDs from Rook #8845
+81
−522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
commented
Sep 27, 2021
travisn
changed the title
travisn
force-pushed
the
volume-replication-optional
branch
from
b81e7e8
to
6649f75
Compare
sp98
reviewed
Sep 28, 2021
leseb
requested changes
Sep 28, 2021
leseb
reviewed
Sep 28, 2021
travisn
force-pushed
the
volume-replication-optional
branch
3 times, most recently
from
2d60357
to
aa9ecac
Compare
sp98
approved these changes
Sep 30, 2021
leseb
reviewed
Sep 30, 2021
images/ceph/Makefile
Outdated
| @@ -104,6 +110,11 @@ generate-csv-templates: $(OPERATOR_SDK) $(YQ) ## Generate CSV templates for OLM | |||
| @OLM_CATALOG_DIR=$(CSV_TEMPLATE_DIR)/cluster/olm/ceph ../../cluster/olm/ceph/generate-rook-csv-templates.sh | |||
| @echo " === Generated CSV templates can be found at $(CSV_TEMPLATE_DIR)/cluster/olm/ceph/templates" | |||
|
|
|||
| get-volume-replication-crds: | |||
| @if [[ -z "$(CURL_TEMPLATE_DIR)" ]]; then echo "CURL_TEMPLATE_DIR is not set"; exit 1; fi | |||
| curl $(VOL_REPL_URL)/$(VOLUME_REPLICATION_CRD) -o $(CURL_TEMPLATE_DIR)/$(VOLUME_REPLICATION_CRD) | |||
There was a problem hiding this comment.
Suggested change
| curl $(VOL_REPL_URL)/$(VOLUME_REPLICATION_CRD) -o $(CURL_TEMPLATE_DIR)/$(VOLUME_REPLICATION_CRD) | |
| curl -L $(VOL_REPL_URL)/$(VOLUME_REPLICATION_CRD) -o $(CURL_TEMPLATE_DIR)/$(VOLUME_REPLICATION_CRD) |
Typically safer if we get a redirect.
travisn
force-pushed
the
volume-replication-optional
branch
2 times, most recently
from
1a0aa7e
to
5cc80bb
Compare
Ok, will go ahead with this and get it included in v1.7.5 |
|
@Mergifyio rebase |
The volume replication CRDs are an external component, not owned by Rook. Therefore, they should be installed as any other independent component in case the admin will install other consumers of the volumereplication CRDs in the future in addition to Rook and the CSI driver. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
|
Command
|
travisn
force-pushed
the
volume-replication-optional
branch
from
5cc80bb
to
c420f23
Compare
mergify bot
added a commit
that referenced
this pull request
Oct 6, 2021
csi: No longer install the VolumeReplication CRDs from Rook (backport #8845)
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
The volume replication CRDs are an external component, not owned by Rook. Therefore, they should be installed as any other independent component in case the admin will install other consumers of the volumereplication CRDs in the future in addition to Rook and the CSI driver.
The volume replication controller in the Ceph-CSI driver was already optional and disabled by default. To enable the volume replication controller there is just now an additional step to install the CRDs if the feature is to be enabled.
Since the CRDs are no longer included with Rook, downstream may need to find a new integration path for the CRDs.
Which issue is resolved by this Pull Request:
Resolves #8573
Checklist:
make codegen) has been run to update object specifications, if necessary.