New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: add context parameter to k8sutil node #9163
Conversation
This pull request has merge conflicts that must be resolved before it can be merged. @y1r please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork |
43b2a80
to
cf2a676
Compare
@leseb I've updated the PR, so could you review this again?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small question
This commit adds context parameter to k8sutil node functions. By this, we can handle cancellation during API call of node resource. Signed-off-by: Yuichiro Ueno <y1r.ueno@gmail.com>
cf2a676
to
4cc716a
Compare
Not yet. I executed grep on the top of rebased this PR:
I'll do them later. |
Ok I reverted my edit, thanks! |
Description of your changes:
This commit adds context parameter to k8sutil node functions. By this,
we can handle cancellation during API call of node resource.
Signed-off-by: Yuichiro Ueno y1r.ueno@gmail.com
Which issue is resolved by this Pull Request:
Part of #8700
Checklist:
make codegen
) has been run to update object specifications, if necessary.