core: add context parameter to k8sutil pod #9164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds context parameter to k8sutil pod functions. By this, we can handle cancellation during API call of pod resource. Signed-off-by: Yuichiro Ueno <y1r.ueno@gmail.com>
leseb
approved these changes
Nov 15, 2021
| @@ -60,16 +60,16 @@ func startOperator(cmd *cobra.Command, args []string) error { | |||
| rook.TerminateFatal(errors.Errorf("rook operator namespace is not provided. expose it via downward API in the rook operator manifest file using environment variable %q", k8sutil.PodNamespaceEnvVar)) | |||
| } | |||
|
|
|||
| rook.CheckOperatorResources(context.Clientset) | |||
| rookImage := rook.GetOperatorImage(context.Clientset, containerName) | |||
| rook.CheckOperatorResources(cmd.Context(), context.Clientset) | |||
There was a problem hiding this comment.
I'm not sure how this context gets canceled or if it ever does. We never initialize it, cobra does if nil. I'm just wondering how useful that is but that's not a problem I believe, at least for code homogeneity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This commit adds context parameter to k8sutil pod functions. By this, we
can handle cancellation during API call of pod resource.
Signed-off-by: Yuichiro Ueno y1r.ueno@gmail.com
Which issue is resolved by this Pull Request:
Part of #8700
Checklist:
make codegen) has been run to update object specifications, if necessary.