Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: Set correct ingress endpoint protocol #9181

Merged
merged 1 commit into from Nov 16, 2021
Merged

helm: Set correct ingress endpoint protocol #9181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions cluster/charts/rook-ceph-cluster/templates/ingress.yaml
View file
Open in desktop
Expand Up @@ -24,11 +24,19 @@ spec:
service:
name: rook-ceph-mgr-dashboard
port:
{{- if .Values.cephClusterSpec.dashboard.ssl }}
name: https-dashboard
{{- else }}
name: http-dashboard
{{- end }}
pathType: Prefix
{{- else }}
serviceName: rook-ceph-mgr-dashboard
{{- if .Values.cephClusterSpec.dashboard.ssl }}
servicePort: https-dashboard
{{- else }}
servicePort: http-dashboard
{{- end }}
{{- end }}
{{- if .Values.ingress.dashboard.tls }}
tls: {{- toYaml .Values.ingress.dashboard.tls | nindent 4 }}
Expand Down
2 changes: 2 additions & 0 deletions cluster/charts/rook-ceph-cluster/values.yaml
View file
Open in desktop
Expand Up @@ -98,6 +98,8 @@ cephClusterSpec:
# urlPrefix: /ceph-dashboard
# serve the dashboard at the given port.
# port: 8443
# serve the dashboard using SSL
ssl: true
Comment on lines +101 to +102
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option only feeds into the ingress object and not to any configs?

Copy link
Member

@BlaineEXE BlaineEXE Nov 16, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nvm. This is the cluster chart that just gets passed through.


# Network configuration, see: https://github.com/rook/rook/blob/master/Documentation/ceph-cluster-crd.md#network-configuration-settings
# network:
Expand Down