Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nfs: only set the pool size when it exists and always run default pool creation #9224

Merged
merged 2 commits into from Nov 24, 2021
Merged

nfs: only set the pool size when it exists and always run default pool creation #9224

merged 2 commits into from Nov 24, 2021

Commits on Nov 23, 2021

  1. nfs: only set the pool size when it exists 

    For CRD not using the new nfs spec that includes the pool settings,
applying the "size" property won't work since it is set to 0. The pool
still gets created but returns an error. The loop is re-queued but on
the second run the pool is detected so no further configuration is done.

Closes: rook#9205
Signed-off-by: Sébastien Han <seb@redhat.com>
    @leseb
    leseb committed Nov 23, 2021
    Copy the full SHA
    c3accdc View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. nfs: always run default pool creation 

    Previously, if the pool was present we would not run the pool creation
again. This is a problem if the pool spec changes, the new settings will
never be applied.

Signed-off-by: Sébastien Han <seb@redhat.com>
    @leseb
    leseb committed Nov 24, 2021
    Copy the full SHA
    f314284 View commit details
    Browse the repository at this point in the history