Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monitoring: allow overriding monitoring labels #9240

Merged
merged 1 commit into from Nov 24, 2021
Merged

monitoring: allow overriding monitoring labels #9240

merged 1 commit into from Nov 24, 2021
+67 −2

Commits on Nov 23, 2021

  1. monitoring: allow overriding monitoring labels 

    The templates for the mgr-generated ServiceMonitor and PrometheusRule objects included the labels
prometheus and team, making it impossible to override them as user.

This adds a new method `OverwriteApplyToObjectMeta` to pkg/apis/rook.io.Labels,
which, contrary to the existing `ApplyToObjectMeta` method, overwrites existing
labels.

Backport of PR rook#9180
Signed-off-by: Mara Sophie Grosch <littlefox@lf-net.org>
    @LittleFox94
    LittleFox94 committed Nov 23, 2021
    Copy the full SHA
    7da43aa View commit details
    Browse the repository at this point in the history