Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: always return nil clusterInfo on failure #9347

Merged
merged 3 commits into from Dec 8, 2021
Merged

core: always return nil clusterInfo on failure #9347

merged 3 commits into from Dec 8, 2021

Commits on Dec 8, 2021

  1. core: always return nil on error 

    We should always return a nil pointer of clusterInfo if
CreateOrLoadClusterInfo() returns an error.

Closes: rook#9314
Signed-off-by: Sébastien Han <seb@redhat.com>
    @leseb
    leseb committed Dec 8, 2021
    Copy the full SHA
    fdd243d View commit details
    Browse the repository at this point in the history

  2. core: fix error message 

    Let's have a more accurate and correct error message that reflects what
the failing function tried to do.

Signed-off-by: Sébastien Han <seb@redhat.com>
    @leseb
    leseb committed Dec 8, 2021
    Copy the full SHA
    4f1a2d4 View commit details
    Browse the repository at this point in the history

  3. core: continue and create an initial cluster info or fail 

    Let's catch the correct error when no cluster info exists yet. If we
have another error, we fail the orchestration and try again. This could
help up catching small API hiccups for example.

Signed-off-by: Sébastien Han <seb@redhat.com>
    @leseb
    leseb committed Dec 8, 2021
    Copy the full SHA
    e5ce6ab View commit details
    Browse the repository at this point in the history