Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: Add RBAC in helm chart for mgr to create service monitor #9383

Closed
wants to merge 1 commit into from

Conversation

sathieu
Copy link
Contributor

@sathieu sathieu commented Dec 10, 2021

Description of your changes:

Same as #8118, for Helm chart.

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@sathieu sathieu marked this pull request as draft December 10, 2021 14:35
@sathieu sathieu marked this pull request as ready for review December 10, 2021 14:55
@sathieu sathieu closed this Dec 10, 2021
@sathieu sathieu reopened this Dec 10, 2021
@sathieu sathieu marked this pull request as draft December 10, 2021 16:33
@sathieu sathieu marked this pull request as ready for review December 10, 2021 16:55
@BlaineEXE
Copy link
Member

Thank you @sathieu for contributing this. We removed recently this bit of code in the operator helm chart because we don't want to strongly tie installation of Rook to Prometheus.

In our example manifests, we have deploy/examples/monitoring/rbac.yaml which deploys the RBAC needed for Prometheus monitoring for users who manually install, and we have the same optional-ness for users of the rook-ceph-cluster Helm chart, which can optionally deploy the monitoring RBAC.

Given that not all users are using the rook-ceph-cluster chart, I have proposed a different solution that will optionally install the required helm resources in the rook-ceph chart. See here: #9388

@sathieu would you care to test that new PR's changes to make sure your workflow is working with it?

Copy link
Member

@BlaineEXE BlaineEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes while we evaluate a different solution.

Signed-off-by: Mathieu Parent <mathieu.parent@insee.fr>
Comment on lines +55 to +58
monitoring:
# enabling will create RBAC rules to allow Operator to create ServiceMonitors
enabled: true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monitoring should not be enabled for all users by default. For our releases that go out to hundreds of users, we'd like this to be false by default, and for those who want monitoring, they enable it via monitoring.enabled.

Copy link
Member

@BlaineEXE BlaineEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please change the subject to helm: ... for our feature tracking. ceph: ... is a bit too generic.

@BlaineEXE
Copy link
Member

Closing now that #9388 is merged.

@BlaineEXE BlaineEXE closed this Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants