New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceph: Add RBAC in helm chart for mgr to create service monitor #9383
Conversation
Thank you @sathieu for contributing this. We removed recently this bit of code in the operator helm chart because we don't want to strongly tie installation of Rook to Prometheus. In our example manifests, we have Given that not all users are using the @sathieu would you care to test that new PR's changes to make sure your workflow is working with it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes while we evaluate a different solution.
Signed-off-by: Mathieu Parent <mathieu.parent@insee.fr>
monitoring: | ||
# enabling will create RBAC rules to allow Operator to create ServiceMonitors | ||
enabled: true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Monitoring should not be enabled for all users by default. For our releases that go out to hundreds of users, we'd like this to be false by default, and for those who want monitoring, they enable it via monitoring.enabled
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please change the subject to helm: ...
for our feature tracking. ceph: ...
is a bit too generic.
Closing now that #9388 is merged. |
Description of your changes:
Same as #8118, for Helm chart.
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen
) has been run to update object specifications, if necessary.