Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr: run the watch side car config on /etc/ceph #9386

Merged
merged 2 commits into from Dec 15, 2021

Commits on Dec 13, 2021

  1. mgr: run active-watch as root and privileged

    For now, we must run the container with UID 0 and privileged for
    multiple reasons:
    
    * the rook binary writes ceph config to /var/lib/rook which is owned by
      root
    * it's difficult to use /etc/ceph since it will conflict with the
      rook-ceph-override configmap AND is also owned by root since it's a
      mounted configmap.
    * using /etc/ceph might be possible but has other issues with rook's
      exec package since the ceph config is built from /var/lib/rook
    
    Closes: rook#9385
    Signed-off-by: Sébastien Han <seb@redhat.com>
    leseb committed Dec 13, 2021
    Copy the full SHA
    5c1e459 View commit details
    Browse the repository at this point in the history
  2. mgr: add missing context to the active-watch sidecar

    The context was not initialized and thus the configmap fetch will fail
    with a nil pointer.
    
    Signed-off-by: Sébastien Han <seb@redhat.com>
    leseb committed Dec 13, 2021
    Copy the full SHA
    892c9a2 View commit details
    Browse the repository at this point in the history