Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: add context parameter to k8sutil endpoint #9393

Merged
merged 1 commit into from Dec 13, 2021
Merged

core: add context parameter to k8sutil endpoint #9393

merged 1 commit into from Dec 13, 2021

Conversation

y1r
Copy link
Contributor

@y1r y1r commented Dec 11, 2021

Description of your changes:

This commit adds context parameter to k8sutil endpoint functions. By
this, we can handle cancellation during API call of endpoint resource.

Signed-off-by: Yuichiro Ueno y1r.ueno@gmail.com

Which issue is resolved by this Pull Request:
Part of #8700

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@y1r
core: add context parameter to k8sutil endpoint
d1d252c 
This commit adds context parameter to k8sutil endpoint functions. By
this, we can handle cancellation during API call of endpoint resource.

Signed-off-by: Yuichiro Ueno <y1r.ueno@gmail.com>
@leseb leseb merged commit 870114f into rook:master Dec 13, 2021
@mergify mergify bot mentioned this pull request Dec 13, 2021
Merged
mergify bot added a commit that referenced this pull request Dec 13, 2021
@mergify
Merge pull request #9405 from rook/mergify/bp/release-1.8/pr-9393
c8d4ff1 
core: add context parameter to k8sutil endpoint (backport #9393)
@y1r y1r deleted the add-context-k8sutil-endpoint branch May 11, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@y1r @leseb