core: add context to k8sutil replicaset and secret #9397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds context parameter to k8sutil replicaset and secret functions. By this, we can handle cancellation during API call of replicaset and secret resource. Signed-off-by: Yuichiro Ueno <y1r.ueno@gmail.com>
leseb
approved these changes
Dec 13, 2021
| @@ -24,8 +24,7 @@ import ( | |||
| ) | |||
|
|
|||
| // DeleteReplicaSet makes a best effort at deleting a deployment and its pods, then waits for them to be deleted | |||
| func DeleteReplicaSet(clientset kubernetes.Interface, namespace, name string) error { | |||
| ctx := context.TODO() | |||
| func DeleteReplicaSet(ctx context.Context, clientset kubernetes.Interface, namespace, name string) error { | |||
There was a problem hiding this comment.
Interesting that DeleteReplicaSet is not used anywhere, it seems useful though, so let's keep it.
mergify bot
added a commit
that referenced
this pull request
Dec 13, 2021
core: add context to k8sutil replicaset and secret (backport #9397)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This commit adds context parameter to k8sutil replicaset and secret
functions. By this, we can handle cancellation during API call of
replicaset and secret resource.
Signed-off-by: Yuichiro Ueno y1r.ueno@gmail.com
Which issue is resolved by this Pull Request:
Part of #8700
Checklist:
make codegen) has been run to update object specifications, if necessary.