Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: always report events #9427

Merged
merged 1 commit into from Dec 20, 2021

Commits on Dec 15, 2021

  1. operator: always report events

    The original PR which added event reporting unnecessarily "optimized" to
    prevent spamming the API controller[1].
    
    It is sometimes important to get events as they happen and not hide new
    events behind preexisting older events. For example, in integration
    tests, we may often want to wait for a controller to finish processing
    an update, and the best way to do that is to wait for the
    "ReconcileSucceeded" event. In order for this to be useful, the events
    must be reported each time.
    
    If we begin having problems with events being reported too often, then
    we should fix the underlying issue of reconciles happening too often
    instead of relying on a time-based "optimization" that hides recent
    event reports that may be useful.
    
    [1]: rook#7222
    
    Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
    BlaineEXE committed Dec 15, 2021
    Copy the full SHA
    da61ac1 View commit details
    Browse the repository at this point in the history