mgr: run the watch side car config on /etc/ceph (backport #9386) #9435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
For now, we must run the container with UID 0 and privileged for multiple reasons: * the rook binary writes ceph config to /var/lib/rook which is owned by root * it's difficult to use /etc/ceph since it will conflict with the rook-ceph-override configmap AND is also owned by root since it's a mounted configmap. * using /etc/ceph might be possible but has other issues with rook's exec package since the ceph config is built from /var/lib/rook Closes: #9385 Signed-off-by: Sébastien Han <seb@redhat.com> (cherry picked from commit 5c1e459)
The context was not initialized and thus the configmap fetch will fail with a nil pointer. Signed-off-by: Sébastien Han <seb@redhat.com> (cherry picked from commit 892c9a2)
travisn
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #9386 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com