Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: fix blockOwnerDeletion error #9441

Merged
merged 1 commit into from Dec 17, 2021
Merged

rgw: fix blockOwnerDeletion error #9441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions deploy/charts/rook-ceph/templates/clusterrole.yaml
View file
Open in desktop
Expand Up @@ -288,6 +288,11 @@ rules:
verbs:
# OBC controller updates OBC and OB statuses
- update
- apiGroups: ["objectbucket.io"]
resources: ["objectbucketclaims/finalizers", "objectbuckets/finalizers"]
verbs:
# OBC controller updates OBC and OB finalizers
- update
---
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
Expand Down
5 changes: 5 additions & 0 deletions deploy/examples/common.yaml
View file
Open in desktop
Expand Up @@ -464,6 +464,11 @@ rules:
verbs:
# OBC controller updates OBC and OB statuses
- update
- apiGroups: ["objectbucket.io"]
resources: ["objectbucketclaims/finalizers", "objectbuckets/finalizers"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about if you add these two resources to line 463 above instead of creating a new api group?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, even thought it's more lines of config, I think it reads better to have these be separate sections. That way, finalizers are independent of status if anything needs to change in the future. Generally speaking, I think this will help keep the permissions more minimal in the long-term.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thoughts for me as @BlaineEXE, but I can change it however you decide it's better. Let me know if you still think it's better to recombine the two api groups.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's functionally the same, so I'm fine going with this for now.

verbs:
# OBC controller updates OBC and OB finalizers
- update
---
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
Expand Down