Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove parent-require dep #1240

Merged

Conversation

kethinov
Copy link
Member

@kethinov kethinov commented May 6, 2023

Turns out it's not needed anymore I guess?

Closes #1062

Closes #1239

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (a79091f) 89.37% compared to head (5415a90) 89.36%.

❗ Current head 5415a90 differs from pull request most recent head 7f52be8. Consider uploading reports for the commit 7f52be8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
- Coverage   89.37%   89.36%   -0.01%     
==========================================
  Files          23       23              
  Lines        3321     3319       -2     
==========================================
- Hits         2968     2966       -2     
  Misses        353      353              
Impacted Files Coverage Δ
lib/preprocessCss.js 88.47% <100.00%> (-0.04%) ⬇️
lib/setExpressConfigs.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kethinov kethinov merged commit e589022 into rooseveltframework:main May 6, 2023
4 of 6 checks passed
@kethinov kethinov deleted the remove-parent-require-dep branch May 6, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Hard fork node-parent-require
1 participant