Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default express-session expiration #1406

Merged
merged 7 commits into from
May 13, 2024

Conversation

awidener3
Copy link
Contributor

Added a maxAge to the express-session default configuration. This prevents the session cookie from expiring when the browser is closed.

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.12%. Comparing base (1668d54) to head (9dfa1fc).

❗ Current head 9dfa1fc differs from pull request most recent head a3dca4d. Consider uploading reports for the commit a3dca4d to get more accurate results

Files Patch % Lines
lib/setExpressConfigs.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1406      +/-   ##
==========================================
- Coverage   85.15%   85.12%   -0.03%     
==========================================
  Files          26       26              
  Lines        3738     3739       +1     
==========================================
  Hits         3183     3183              
- Misses        555      556       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lib/setExpressConfigs.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@kethinov kethinov merged commit 4fb4e21 into rooseveltframework:main May 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants