Support Visual Studio 2017 #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… replace $VERSION field.
Detecting a VS2017 install is significantly different than prior versions. This is particularly true in the case of environment variables, which are not added globally, meaning launching cling from a random shell would fail. Additionally, prior implementation did not block clang from doing it’s own detection, which added the paths it found with the -isystem flag so that they had priority over what cling was trying to use.
By using the command-line flags, clang will know this information early, rather than having it changed from underneath.
…e paths added with -isystem.
|
Really hope this features. |
|
Would also love to see this get merged in. I'd also like to mention the vswhere tool which is the Microsoft recommended way to get information about installed Visual Studio versions. |
|
I think this repo is just a mirror, consider moving your PR here instead: https://github.com/root-project/root/pulls (subdirectory interpreter/cling). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How a modern Visual Studio is installed/detected changes quite a bit.