Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter and other classes have been modified for support null args #232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bisegni
Copy link

@bisegni bisegni commented May 2, 2018

This patch permit to use interpreter without give the argc(0) and argv(nullptr)

Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate the white-space/layout changes from the active changes. Thanks.

std::vector<const char*> argvCompile;
if(argc && argv) {
argvCompile = std::vector<const char*>(argv, argv+1);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better/needed to have a non-empty default for argvCompile?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for replay, this is a first patch, to permit to use it. I'd like to share ideas on the architectural design to follow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this repo is just a mirror, consider moving your PR here instead: https://github.com/root-project/root/pulls (subdirectory interpreter/cling). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants