Fix CMake build instructions #518
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This simple PR seems super important to me. I wonder how many people, almost like myself, spending hours trying to follow the build instructions and failing, simply give up and don't use it or become involved. Seems a shame not to make the very simple change of providing proper build instructions in the README that work in 2024. |
ferdymercury
requested review from
vgvassilev
and removed request for
vgvassilev
|
I believe this repo acts as a mirror, please move your PR here instead: https://github.com/root-project/root/pulls (subdirectory interpreter/cling). Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple PR to improve the CMake build instructions. The existing ones are a bit too convoluted and can be simplified a lot, plus there is an issue mentioned at #515 about the
NVPTXusing the wrong name, which leads to a misleading error. (The first issue mentioned there about the build type only shows when you configure CMake with a non-multi-config generator, so I've left that one alone for the time being).I hope this helps!