Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webroot config for Apache and Nginx with the {{root}} variable included #474

Open
wants to merge 1 commit into
base: docs
Choose a base branch
from

Conversation

Sowgenius
Copy link

It's basically a simpler way to setup everything

Copy link
Member

@swalkinshaw swalkinshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two minor tweaks


This how it should look like in the file ( Apache config - file is located at `~/Local Sites/bedrock/conf/apache/site.conf.hbs`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This how it should look like in the file ( Apache config - file is located at `~/Local Sites/bedrock/conf/apache/site.conf.hbs`)
This what it should look like in the file (Apache config - file is located at `~/Local Sites/bedrock/conf/apache/site.conf.hbs`)

Comment on lines +90 to +92
ServerAdmin webmaster@localhost
DocumentRoot "{{root}}/web"
[...]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ServerAdmin webmaster@localhost
DocumentRoot "{{root}}/web"
[...]
ServerAdmin webmaster@localhost
DocumentRoot "{{root}}/web"
[...]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants