Skip to content

Commit

Permalink
Migrate to Node.js v20 (#679)
Browse files Browse the repository at this point in the history
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
  • Loading branch information
mikaelarguedas committed May 11, 2024
1 parent 708543a commit 910b021
Show file tree
Hide file tree
Showing 7 changed files with 531 additions and 512 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4.0.2
with:
node-version: "16.x"
node-version: "20.x"
- run: npm install && npm run lint
- run: npm run build && git diff --exit-code
14 changes: 7 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4.0.2
with:
node-version: "16.x"
node-version: "20.x"
- run: .github/workflows/build-and-test.sh
- uses: ./ # Uses an action in the root directory
- run: .github/workflows/check-environment.sh
Expand All @@ -51,7 +51,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4.0.2
with:
node-version: "16.x"
node-version: "20.x"
- run: .github/workflows/build-and-test.sh
- uses: ./ # Uses an action in the root directory
- run: .github/workflows/check-environment.sh
Expand All @@ -78,7 +78,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4.0.2
with:
node-version: "16.x"
node-version: "20.x"
- run: .github/workflows/build-and-test.sh
- uses: ./ # Uses an action in the root directory
with:
Expand Down Expand Up @@ -144,7 +144,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4.0.2
with:
node-version: "16.x"
node-version: "20.x"
- run: .github/workflows/build-and-test.sh
- uses: ./ # Uses an action in the root directory
with:
Expand All @@ -166,7 +166,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4.0.2
with:
node-version: "16.x"
node-version: "20.x"
- run: .github/workflows/build-and-test.sh
- run: cp .github/workflows/test_setup.cfg setup.cfg
- uses: ./ # Uses an action in the root directory
Expand All @@ -181,7 +181,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4.0.2
with:
node-version: "16.x"
node-version: "20.x"
- run: .github/workflows/build-and-test.sh
- uses: ./

Expand All @@ -199,7 +199,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4.0.2
with:
node-version: "16.x"
node-version: "20.x"
- run: .github/workflows/build-and-test.sh
- uses: ./
with:
Expand Down
2 changes: 1 addition & 1 deletion DEVELOPING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

Install [Node.js](https://nodejs.org/en/download/).

We are currently using Node.js v16.
We are currently using Node.js v20.

## Install Dependencies

Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ inputs:
required: false
default: ""
runs:
using: "node16"
using: "node20"
main: "dist/index.js"
12 changes: 6 additions & 6 deletions dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6698,8 +6698,8 @@ exports.runAptGetInstall = runAptGetInstall;
*
* @returns Promise<number> exit code
*/
function installAptDependencies(installConnext = false) {
return __awaiter(this, void 0, void 0, function* () {
function installAptDependencies() {
return __awaiter(this, arguments, void 0, function* (installConnext = false) {
const distribCodename = yield utils.determineDistribCodename();
let aptPackages = installConnext
? aptDependencies.concat(aptRtiConnextDds[distribCodename] || [])
Expand Down Expand Up @@ -7075,8 +7075,8 @@ const pip3CommandLine = ["pip3", "install", "--upgrade"];
* @param run_with_sudo whether to prefix the command with sudo
* @returns Promise<number> exit code
*/
function runPython3PipInstall(packages, run_with_sudo = true) {
return __awaiter(this, void 0, void 0, function* () {
function runPython3PipInstall(packages_1) {
return __awaiter(this, arguments, void 0, function* (packages, run_with_sudo = true) {
const args = pip3CommandLine.concat(packages);
// Set CWD to root to avoid running 'pip install' in directory with setup.cfg file
const options = {
Expand All @@ -7099,8 +7099,8 @@ exports.runPython3PipInstall = runPython3PipInstall;
* @param run_with_sudo whether to prefix the command with sudo
* @returns Promise<number> exit code
*/
function installPython3Dependencies(run_with_sudo = true, packages = pip3Packages) {
return __awaiter(this, void 0, void 0, function* () {
function installPython3Dependencies() {
return __awaiter(this, arguments, void 0, function* (run_with_sudo = true, packages = pip3Packages) {
if (packages.length === 0) {
return 0;
}
Expand Down

0 comments on commit 910b021

Please sign in to comment.