-
-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yolo test_callback_segfault_simple #7218
base: develop
Are you sure you want to change the base?
Conversation
56cd762
to
6090af4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7218 +/- ##
===========================================
- Coverage 73.46% 73.21% -0.26%
===========================================
Files 1236 1236
Lines 106595 106245 -350
Branches 12390 12336 -54
===========================================
- Hits 78310 77783 -527
- Misses 26410 26589 +179
+ Partials 1875 1873 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Test passed on its own |
94aa280
to
47784d3
Compare
This shit won''t fail. Tried |
47784d3
to
be7de49
Compare
Running the entire "others" backend tests makes it fail: |
be7de49
to
f0df03c
Compare
f0df03c
to
b44a358
Compare
Okay made it fail nicely and fast by Unfortunately only on the CI |
06858b7
to
bfae076
Compare
Canceled the workflow as it passed the test without failing. So adding TRACE logging makes it not happen. Which ... helps us not. |
d954288
to
debd219
Compare
Even increasing the events and decreasing sql_vm_instructions_cb makes this pass. Canceled the workflow again. |
debd219
to
665225f
Compare
Okay nice so going back to no trace and no test changes reproduces immediately. At least that's something. Wish I could do this locally. |
No description provided.