Disable background tasks during PnL process #7845
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the PnL report ensure that no background task gets scheduled that could slow down the task that the user has requested
yabirgb
force-pushed
the
disable-bg-tasks
branch
from
5e11cde
to
564a7e6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7845 +/- ##
===========================================
- Coverage 78.17% 77.75% -0.42%
===========================================
Files 969 969
Lines 63141 63141
Branches 11092 11092
===========================================
- Hits 49358 49098 -260
- Misses 11597 11843 +246
- Partials 2186 2200 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LefterisJP
reviewed
Apr 26, 2024
| @@ -541,6 +541,8 @@ def delete_async_task(self, task_id: int) -> Response: | |||
| ): | |||
| log.debug(f'Killing api task greenlet with {task_id=}') | |||
| greenlet.kill(exception=GreenletKilledError('Killed due to api request')) | |||
| # if a task has disabled the task manager ensure that it gets reactivated | |||
| self.rotkehlchen.task_manager.should_schedule = True # type: ignore[union-attr] # here task manager is not None | |||
There was a problem hiding this comment.
I don't understand what this is here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the PnL report ensure that no background task gets scheduled that could slow down the task that the user has requested
Closes #(issue_number)
Checklist